Why can't i find my minecraft server?

Many (if not most) routers do not do loopback (LAN2 LAN via WAN IP) likely to avoid IP spoofing (sending a packet from the internet with fake source address of private LAN IP). So an initial test is to make sure your server is working when you connect to its LAN IP from another computer on the same LAN. If that fails you need to get that working first.

Then assuming that you configured your port forwarding, test from the internet with something like http://www.canyouseeme.org/ to see if that sees port 25565 (or whatever port you configured for minecraft) as an open port. Then test it from a computer that is NOT on your LAN, like using mobile data, dial up networking, from a friend's home, whatever, to confirm that it works from the internet.

Since most people have a dynamic public IP address (whether it changes often or rarely) it helps to have some sort of dynamic DNS set up and working, so players can find your server by a fixed name instead of possibly changing IP address. I have used no-ip.com, but you can find others by web searching 'dns hosting'. Sometimes you can use a free subdomain, or if you use your own domain that you registered there may be a minimal annual fee.