My Minecraft Server IP won't work for other people?

So I JUST made a minecraft server and gave the IP address to a friend. He then said that the IP I gave him (I'm pretty sure this was right because it says that this is the IP in the server notepad) didn't work.
Help? ;-;

Added (1). I forgot to mention,
the IP worked for me.

Make sure you port forward it and that the 25565 port FOR the game itself is open.

You should make sure the right port is opened, and that your router directs incoming traffic to you computer. If you can't work out how to do this you should wonder if running a server is for you. Opening ports creates potential security risks.

And you should ensure that you are giving the ip that you give out is the external ip number, not your intranet ip number. Intranet ip addresses usually start 192.168, your external ip number can be checked with "what's my ip" and other sources.