Why won't my mincraft server work?

I have my ports forwarded and it has worked a bunch of times i had it up not even a week ago i can get on it but for some reason my friends can't i gave them the right ip and they have played before like a said not even a week ago we were all on it i can't seem to see why it won't work i have excellent internet and everything is setup correctly and has worked fine many times please help me.

You could have several problems-
Your local IP is dynamic, if you use dcph then is is likely.
Your public IP is dynamic (99% of the time it is) , give them the latest version.
The UDP port is used, TCP should be.
An antivirus (Mcafee does this) Forcibly blocks ports.
Your windows firewall is set to block ports.
Your network is seen as a public network in windows.
Your network operator forcibly firewalls ports.
Your ip binding in your server settings are wrong
Your server is lagging to much with one person and no one else can join.