Minecraft server so close?

I have the port open, i checked, and i set the exception rules for inbound and outbound, made sure all the javas had public, and gave my friends my public ip but they still can't join. I thought i did everything right this time D

Have you checked your windows firewall? Once I spent hours checking ports/ip's etc and laughed hysterically when I realized that windows firewall was blocking minecraft/java. Try disabling the firewall and if it works turn it back on/add an exception for minecraft. Also make sure you're using a public and not a private IP. Google "what is my ip." Although I bet you already got that I thought I would check