Minecraft Server IP isn't working for me

I have created a Minecraft server for me and my friends and the IP doesn't work for me or my friends. The server itself is fine because putting "localhost" as the IP works for me, but when I put in my IP with:25565 at the end it doesn't work. The whole thing is fine, I have a custom world in it and 3GB of ram for it, but the only that's messed up is the IP. Anyone that can help please do.

Firstly, you want to make sure you are giving out your public IP and not your local one. Local ones usually start with 192.xxx.x.x, your public ip can be found on something like www.whatismyip.com. Second, if that's not the problem, then you need to port forward, done by logging into your router and accessing the port forward options- you can find more info on this through google (minecraft port forwarding). Other then these I don't know, you might also want to try without the:25565

Also if your connecting through your network you should be using localhost and your friends outside the network should be using your WAN IP address and Port#.