Minecraft Server. People can't join?

So i made a minecraft server i port forwarded my ipv4 address, and its a vanilla server from minecraft.net but when i give peopel my local ip with the 25565 port they can't join please help!

Did you port forward both through your router AND through your computers firewall? Also did you forward inbound and outbound?

Make sure your ipv4 is TCP and UCP (also known as inbound and outbound) when you port forward. You also need to type in your IP address in the notepad file of your server settings of Minecraft. Also make sure in the text file, make online mode to true, known as "1" in Boolean Algebra/Binary.

Disabling your firewall might also help.

Also use this website to check if you're server is online.

http://www.yougetsignal.com/tools/open-ports/

Remote Address is your ipv4 and then port number is obviously 25565.