Should I buy an Xbox One S Minecraft Limited Edition or an Xbox One X?

If you don't have a 4k TV, aren't planning on buying one, and don't care about gaming in 4k, then just get the Xbox One S.

You'll only see any benefit with a Xbox One X if you have a 4k TV.